On Thu, May 09, 2024 at 03:07:17PM +0100, David Howells wrote: > Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > I think this should just be removed unconditionally, since the VFS now > > takes care of mode masking in vfs_prepare_mode(). > > That works for symlinks because the symlink path doesn't call it? All of the mode handling should now be done correctly in the VFS (see Miklos reply as well). In general the less fs specific mode handling we have, the better because we've been bitten by this before.