Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miklos Szeredi <miklos@xxxxxxxxxx>
Subject: Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
From: David Howells <dhowells@xxxxxxxxxx>
Date: Thu, 09 May 2024 15:07:17 +0100
Cc: dhowells@xxxxxxxxxx, Max Kellermann <max.kellermann@xxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <CAJfpegtJbDc=uqpP-KKKpP0da=vkxcCExpNDBHwOdGj-+MsowQ@mail.gmail.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <CAJfpegtJbDc=uqpP-KKKpP0da=vkxcCExpNDBHwOdGj-+MsowQ@mail.gmail.com> <1553599.1715262072@warthog.procyon.org.uk>

Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> I think this should just be removed unconditionally, since the VFS now
> takes care of mode masking in vfs_prepare_mode().

That works for symlinks because the symlink path doesn't call it?

David

Follow-Ups:
- Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
  - From: Christian Brauner
- Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
  - From: Miklos Szeredi

References:
- Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
  - From: Miklos Szeredi
- [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
  - From: David Howells

Prev by Date: Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
Next by Date: Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
Previous by thread: Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
Next by thread: Re: [PATCH] ext4: Don't reduce symlink i_mode by umask if no ACL support
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]