Hi, This is the v5 of this patchset. Thanks Christian and Eric for you review. In this version, the patchset grew a bit because it adds: - a preparation patch to merge d_revalidate_name and d_revalidate, attending Christian's request. The original patch is now touching several filesystems to update the hook signature, so it has grown quite a bit. But, all of that was autogenerated with coccinelle and tested with allyesconfig only. - A new patch to expose a helper from libfs that I use in ecryptfs. - Code to prevent ecryptfs from mounting on top of casefolded directories. Also following on Christian's review. Other than these, there are some minor fixes, listed in each patch changelog, and more clarifications on the locking, thanks to the excellent feedback from Eric. Eric, I believe I have covered the cases where instantiation can happen and I don't think it is possible for a dentry to become positive amidst the d_revalidation, since we are holding the inode parent lock to synchronize with creations. Please let me know if you find anything else. Finally, I've dropped the r-b tags from patch "fs: Expose name under lookup to d_revalidate hooks", because it changed too much since the time of review. Regarding testing, I verified it doesn't regress fstests for f2fs and ext4, verified building all filesystems work fine with allyesconfig, even with variation of CONFIG_FS_ENCRYPTION and CONFIG_UNICODE, and, finally, I checked I wasn't able to mount or lookup casefolded directories with ecryptfs and overlayfs. Thanks, Gabriel Krisman Bertazi (10): fs: Expose helper to check if a directory needs casefolding ecryptfs: Reject casefold directory inodes 9p: Split ->weak_revalidate from ->revalidate fs: Expose name under lookup to d_revalidate hooks fs: Add DCACHE_CASEFOLDED_NAME flag libfs: Validate negative dentries in case-insensitive directories libfs: Chain encryption checks after case-insensitive revalidation libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops ext4: Enable negative dentries on case-insensitive lookup f2fs: Enable negative dentries on case-insensitive lookup Documentation/filesystems/locking.rst | 3 +- Documentation/filesystems/vfs.rst | 11 ++- fs/9p/vfs_dentry.c | 11 ++- fs/afs/dir.c | 6 +- fs/afs/dynroot.c | 4 +- fs/ceph/dir.c | 3 +- fs/coda/dir.c | 3 +- fs/crypto/fname.c | 3 +- fs/dcache.c | 8 ++ fs/ecryptfs/dentry.c | 5 +- fs/ecryptfs/inode.c | 8 ++ fs/exfat/namei.c | 3 +- fs/ext4/namei.c | 35 +------- fs/f2fs/namei.c | 25 +----- fs/fat/namei_vfat.c | 6 +- fs/fuse/dir.c | 3 +- fs/gfs2/dentry.c | 3 +- fs/hfs/sysdep.c | 3 +- fs/jfs/namei.c | 3 +- fs/kernfs/dir.c | 3 +- fs/libfs.c | 124 +++++++++++++++++--------- fs/namei.c | 18 ++-- fs/nfs/dir.c | 9 +- fs/ocfs2/dcache.c | 4 +- fs/orangefs/dcache.c | 3 +- fs/overlayfs/super.c | 20 +++-- fs/proc/base.c | 6 +- fs/proc/fd.c | 3 +- fs/proc/generic.c | 6 +- fs/proc/proc_sysctl.c | 3 +- fs/reiserfs/xattr.c | 3 +- fs/smb/client/dir.c | 3 +- fs/vboxsf/dir.c | 4 +- include/linux/dcache.h | 10 ++- include/linux/fs.h | 21 +++++ include/linux/fscrypt.h | 4 +- 36 files changed, 242 insertions(+), 148 deletions(-) -- 2.41.0
