on 7/21/2023 11:55 PM, Ritesh Harjani wrote: > Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> writes: > >> Hi all, this series contains some random fixes and cleanups to mballoc >> which include correct grp validation, fix data overflow and so on. >> More details can be found in respective patches. >> Besides, 'kvm-xfstest smoke' runs successfully without error. > > Thanks Kemeng for the cleanup series. Looks good to me with few minor > nits which I have commented in individual patches. > Hi Ritesh, thanks for the review and comments. I went through all your suggestions and they help a lot. I will send v2 patchset to handle these. > Note that I couldn't cleanly apply the series on ted's dev branch > (Patch-05 gave some minor conflict). Maybe you might have based your > changes on top of linux master or something. Anyways it was just a minor > conflict and I don't know what is Ted's general preference here, but I > thought of doing an FYI - Sorry for the conflict, this patchset is based on cleanup patchset [1] which you have noticed. As [1] still needs a lot more review, I will make this patchset based on current dev branch. Thanks! [1] https://lore.kernel.org/linux-ext4/20230629144007.1263510-1-shikemeng@xxxxxxxxxxxxxxx/T/#m66729346a76498079278df3e132a89910860f8ff -- Best wishes Kemeng Shi
