On Sun 18-06-23 23:32:49, Bean Huo wrote: > From: Bean Huo <beanhuo@xxxxxxxxxx> > > Remove unnecessary check on the return value of block_commit_write(). > > Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/ocfs2/file.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index efb09de4343d..39d8dbb26bb3 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -808,12 +808,7 @@ static int ocfs2_write_zero_page(struct inode *inode, u64 abs_from, > > > /* must not update i_size! */ > - ret = block_commit_write(page, block_start + 1, > - block_start + 1); > - if (ret < 0) > - mlog_errno(ret); > - else > - ret = 0; > + block_commit_write(page, block_start + 1, block_start + 1); > } > > /* > -- > 2.34.1 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
