On Sun 18-06-23 23:32:50, Bean Huo wrote:
> From: Bean Huo <beanhuo@xxxxxxxxxx>
>
> Remove unnecessary check on the return value of block_commit_write().
>
> Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/udf/file.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/udf/file.c b/fs/udf/file.c
> index 8238f742377b..b1a062922a24 100644
> --- a/fs/udf/file.c
> +++ b/fs/udf/file.c
> @@ -67,13 +67,13 @@ static vm_fault_t udf_page_mkwrite(struct vm_fault *vmf)
> else
> end = PAGE_SIZE;
> err = __block_write_begin(page, 0, end, udf_get_block);
> - if (!err)
> - err = block_commit_write(page, 0, end);
> - if (err < 0) {
> + if (err) {
> unlock_page(page);
> ret = block_page_mkwrite_return(err);
> goto out_unlock;
> }
> +
> + block_commit_write(page, 0, end);
> out_dirty:
> set_page_dirty(page);
> wait_for_stable_page(page);
> --
> 2.34.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
