On Sat 03-12-22 23:06:47, Christoph Hellwig wrote: > > + * This function is now used only when journaling data. We cannot start > > + * transaction directly because transaction start ranks above page lock so we > > + * have to do some magic. > > */ > > +static int ext4_writepage(struct page *page, struct writeback_control *wbc, > > + void *data) > > Maybe call this ext4_journalled_writepage now to make the limitation > more clear? And/or fold __ext4_journalled_writepage into while we're > at it. Yeah, I've renamed it to ext4_journalled_writepage. I've refrained from the folding of __ext4_journalled_writepage() because that is not completely trivial (due to goto labels, variable naming...) so it would require separate patch and I'll just spare that for the cleanup of the whole journalled writeout path. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
