> + * This function is now used only when journaling data. We cannot start > + * transaction directly because transaction start ranks above page lock so we > + * have to do some magic. > */ > +static int ext4_writepage(struct page *page, struct writeback_control *wbc, > + void *data) Maybe call this ext4_journalled_writepage now to make the limitation more clear? And/or fold __ext4_journalled_writepage into while we're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
