On 22/09/03 11:01AM, Jason Yan wrote: > Factor out ext4_journal_data_mode_check(). No functional change. > > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx> > Reviewed-by: Jan Kara<jack@xxxxxxx> > --- > fs/ext4/super.c | 60 ++++++++++++++++++++++++++++--------------------- > 1 file changed, 35 insertions(+), 25 deletions(-) Looks good to me. Thanks overall for the nice refactoring. Function __ext4_fill_super() indeed looks a lot better now :) Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>