Hi Jan,
On Tue, Sep 06, 2022 at 05:29:11PM +0200, Jan Kara wrote:
>
> ** snip **
> /*
> * Choose next group by traversing average fragment size tree. Updates *new_cr
Maybe we can change this to "average fragment size list of suitable
order"
> - * if cr lvel needs an update. Sets EXT4_MB_SEARCH_NEXT_LINEAR to indicate that
> - * the linear search should continue for one iteration since there's lock
> - * contention on the rb tree lock.
> + * if cr level needs an update.
> */
> static void ext4_mb_choose_next_group_cr1(struct ext4_allocation_context *ac,
> int *new_cr, ext4_group_t *group, ext4_group_t ngroups)
> {
> struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
> - int avg_fragment_size, best_so_far;
> - struct rb_node *node, *found;
> - struct ext4_group_info *grp;
Other than that, this patch along with the updated mb_structs_summary
proc file change looks good to me.
Regards,
Ojaswin
