On 2022/8/31 19:55, Jan Kara wrote:
On Tue 30-08-22 20:04:07, Jason Yan wrote:
Factor out ext4_compat_feature_check(). No functional change.
Signed-off-by: Jason Yan<yanaijie@xxxxxxxxxx>
---
fs/ext4/super.c | 144 ++++++++++++++++++++++++++----------------------
1 file changed, 77 insertions(+), 67 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 96cf23787bba..1e7d6eb6a3aa 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4607,6 +4607,82 @@ static int ext4_handle_csum(struct super_block *sb, struct ext4_super_block *es)
return 0;
}
+static int ext4_compat_feature_check(struct super_block *sb,
+ struct ext4_super_block *es,
+ int silent)
And here maybe ext4_check_feature_compatibility() might be a better name
because "compat_feature" is a name of a specific subset of ext4 features so
using it in function name is a bit confusing. Otherwise feel free to add:
Indeed.
Thanks.
Reviewed-by: Jan Kara<jack@xxxxxxx>
