On 2022/8/31 19:52, Jan Kara wrote:
On Tue 30-08-22 20:04:06, Jason Yan wrote:
Factor out ext4_handle_csum(). No functional change.
Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
---
fs/ext4/super.c | 83 +++++++++++++++++++++++++++----------------------
1 file changed, 46 insertions(+), 37 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9ee27472b802..96cf23787bba 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4563,6 +4563,50 @@ static int ext4_encoding_init(struct super_block *sb, struct ext4_super_block *e
return 0;
}
+static int ext4_handle_csum(struct super_block *sb, struct ext4_super_block *es)
I'd rather call this function like ext4_init_metadata_csum().
ext4_handle_csum() seems to vague to me.
Yes, much better.
Thanks.
Otherwise the patch looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
