On Thu, 18 Aug 2022 20:20:02 +0530 Matthew Wilcox wrote: > I don't think changing these from u64 to s64 is the right way to go. Why do you think so? Is there somnething I overlooked? I think it won't intorduce regression, since if something is working, it will continue to work. If something does break, then they were relying on overflows, which is anyways an incorrect way to go about. Also, it seems even the 32-bit compatibility structure uses signed types. Thanks, Siddh