On Sat 05-02-22 19:39:56, Ritesh Harjani wrote:
> This API will be needed at places where we don't have an inode
> for e.g. while freeing blocks in ext4_group_add_blocks()
>
> Suggested-by: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>
...
> @@ -329,7 +324,8 @@ int ext4_inode_block_valid(struct inode *inode, ext4_fsblk_t start_blk,
> else if (start_blk >= (entry->start_blk + entry->count))
> n = n->rb_right;
> else {
> - ret = (entry->ino == inode->i_ino);
> + if (inode)
> + ret = (entry->ino == inode->i_ino);
> break;
In case inode is not passed, we must not overlap any entry in the rbtree.
So we should return 0, not 1.
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
