Hello, Please find v1 of this patch series aimed at fixing some of the issues identified in fast_commit. This also adds some stricter checking of blocks to be freed in ext4_mb_clear_bb(), ext4_group_add_blocks() & ext4_mb_mark_bb(). I have tested this with few different fast_commit configs and normal 4k config with -g log,quick. Haven't seen any surprises there. RFC -> v1: ========== 1. Added Patch-1 which correctly accounts for flex_bg->free_clusters. 2. Addressed review comments from Jan 3. Might have changed the order of patches a bit. [RFC] - https://lore.kernel.org/all/a9770b46522c03989bdd96f63f7d0bfb2cf499ab.1643642105.git.riteshh@xxxxxxxxxxxxx/ Ritesh Harjani (9): ext4: Correct cluster len and clusters changed accounting in ext4_mb_mark_bb ext4: Fixes ext4_mb_mark_bb() with flex_bg with fast_commit ext4: Refactor ext4_free_blocks() to pull out ext4_mb_clear_bb() ext4: Use in_range() for range checking in ext4_fc_replay_check_excluded ext4: Rename ext4_set_bits to mb_set_bits ext4: No need to test for block bitmap bits in ext4_mb_mark_bb() ext4: Add ext4_sb_block_valid() refactored out of ext4_inode_block_valid() ext4: Add strict range checks while freeing blocks ext4: Add extra check in ext4_mb_mark_bb() to prevent against possible corruption fs/ext4/block_validity.c | 25 +-- fs/ext4/ext4.h | 5 +- fs/ext4/fast_commit.c | 4 +- fs/ext4/mballoc.c | 342 ++++++++++++++++++++++----------------- fs/ext4/resize.c | 4 +- 5 files changed, 219 insertions(+), 161 deletions(-) -- 2.31.1
