On Sat 21-08-21 07:58:07, Matthew Bobrowski wrote: > On Fri, Aug 20, 2021 at 12:21:19PM +0200, Petr Vorel wrote: > > Hi all, > > > > > No problem. That's what review is for ;-) > > > > > BTW, unless anyone is specifically interested I don't think there > > > is a reason to re post the test patches before the submission request. > > > Certainly not for the small fixes that I requested. > > > > > I do request that you post a link to a branch with the fixed test > > > so that we can experiment with the kernel patches. > > > > > I've also CC'ed Matthew who may want to help with review of the test > > > and man page that you posted in the cover letter [1]. > > > > @Amir Thanks a lot for your review, agree with all you mentioned. > > > > @Gabriel Thanks for your contribution. I'd also consider squashing some of the > > commits. > > Is the FAN_FS_ERROR feature to be included within the 5.15 release? If so, > I may need to do some shuffling around as these LTP tests collide with the > ones I author for the FAN_REPORT_PIDFD series. No, I don't think FAN_FS_ERROR is quite ready for the coming merge window. So you should be fine. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
