On Fri 20-08-21 17:07:39, Theodore Ts'o wrote: > On Fri, Aug 20, 2021 at 06:15:02PM +0200, Jan Kara wrote: > > OpenSUSE Tumbleweed now has libreadline.so.8. Add it to the list of libs > > to look for. > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > --- > > lib/ss/get_readline.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Hum, why don't we look for libreadline.so BTW? That way we could save adding > > now so version whenever one appears? > > We do actually look for libreadline.so; it's right after > libreadline.so.4: > > > -#define DEFAULT_LIBPATH "libreadline.so.7:libreadline.so.6:libreadline.so.5:libreadline.so.4:libreadline.so:libedit.so.2:libedit.so:libeditline.so.0:libeditline.so" > > However, we still need the libreadline.so.N in the path because at > least for some distributions, they only install libreadline.so if you > install the -dev package. For example, in Debian, libreadline.so.8 is > installed from the libreadline8 package, while libreadline.so is > installed from the libreadline-dev package (and it's not guaranteed to > be installed). Oh, right. I've just checked and on my openSUSE machine libreadline.so is also only provided by readline-devel package (which I have installed so I didn't originally noticed). Thanks for explanation. I'm just wondering if there isn't a better way to search for a suitable library... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
