On Tue 03-08-21 12:57:36, Theodore Ts'o wrote:
> On Mon, Jul 12, 2021 at 05:43:10PM +0200, Jan Kara wrote:
> > @@ -825,6 +826,7 @@ struct ext2_super_block {
> > #define EXT4_FEATURE_RO_COMPAT_GDT_CSUM 0x0010
> > #define EXT4_FEATURE_RO_COMPAT_DIR_NLINK 0x0020
> > #define EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE 0x0040
> > +#define EXT4_FEATURE_RO_COMPAT_ORPHAN_PRESENT 0x0080
> > #define EXT4_FEATURE_RO_COMPAT_QUOTA 0x0100
> > #define EXT4_FEATURE_RO_COMPAT_BIGALLOC 0x0200
>
> (This isn't a full review of the patch, but just a quick feedback of
> what I've noticed so far.)
>
> Since Andreas has requested that we not get rid of the
> RO_COMPAT_SNAPSHOT, I'm using 0x0400 for
> EXT4_FEATURE_RO_COMPAT_ORPHAN_PRESENT in my testing.
Yeah, I'm sorry. Somehow older version of the patch escaped to this posting
(I've checked and this was the only difference between what I have in git
and what I have posted).
> I also noted a number of new GCC warnings when running "make gcc-wall"
> on lib/ext2fs after applying this commit.
I'll check these fix them up and repost. Thanks for noticing.
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
