On Mon, Jan 04, 2021 at 04:54:49PM -0800, Eric Biggers wrote:
> + } else {
> + /*
> + * Else it's either I_DIRTY_PAGES, I_DIRTY_TIME, or nothing.
> + * (We don't support setting both I_DIRTY_PAGES and I_DIRTY_TIME
> + * in one call to __mark_inode_dirty().)
> + */
> + dirtytime = flags & I_DIRTY_TIME;
> + WARN_ON_ONCE(dirtytime && (flags != I_DIRTY_TIME));
No need for the inner braces here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
