Hello, This patchset fixes the lazytime bug which I reported last year (https://lore.kernel.org/r/20200306004555.GB225345@xxxxxxxxx). This bug causes inodes with dirty timestamps to remain dirty after a sync, which causes the inodes to be unnecessarily written again, and also causes the FS_IOC_REMOVE_ENCRYPTION_KEY ioctl to not work properly. This bug is causing xfstest generic/580 to fail when lazytime is enabled. Ted and Christoph proposed fixes for this. Ted's fix (https://lore.kernel.org/r/20200307020043.60118-1-tytso@xxxxxxx) changed the call to mark_inode_dirty_sync(inode) in __writeback_single_inode() to ->dirty_inode(inode, I_DIRTY_TIME_EXPIRED). However this would have broken XFS, which wants an I_DIRTY_SYNC notification. Also, people preferred a larger rework involving adding a ->lazytime_expired method. Christoph's fix (https://lore.kernel.org/r/20200325122825.1086872-3-hch@xxxxxx) introduced ->lazytime_expired, but it wasn't correct because it didn't consider cases in which timestamps are force-expired. To resolve this, I propose that we first fix the bug by making __writeback_single_inode() do an I_DIRTY_SYNC notification if the timestamps expired (patch #1). Then, the remaining patches introduce ->lazytime_expired and make XFS use it. They also clean up various things, such as improving comments. Also, it turns out that lazytime on XFS is broken because it doesn't actually write timestamps to disk after a sync() or after 24 hours. This is fixed by the patch to switch XFS to use ->lazytime_expired. I've written an xfstest which reproduces this bug. This patchset applies to v5.11-rc2. Eric Biggers (13): fs: avoid double-writing inodes on lazytime expiration gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() fs: only specify I_DIRTY_TIME when needed in generic_update_time() fat: only specify I_DIRTY_TIME when needed in fat_update_time() fs: don't call ->dirty_inode for lazytime timestamp updates fs: pass only I_DIRTY_INODE flags to ->dirty_inode fs: correctly document the inode dirty flags ext4: simplify i_state checks in __ext4_update_other_inode_time() fs: drop redundant checks from __writeback_single_inode() fs: clean up __mark_inode_dirty() a bit fs: add a lazytime_expired method xfs: remove a stale comment from xfs_file_aio_write_checks() xfs: implement lazytime_expired Documentation/filesystems/locking.rst | 2 + Documentation/filesystems/vfs.rst | 15 ++++- fs/ext4/inode.c | 20 ++---- fs/f2fs/super.c | 3 - fs/fat/misc.c | 21 +++--- fs/fs-writeback.c | 94 +++++++++++++++++++-------- fs/gfs2/file.c | 4 +- fs/gfs2/super.c | 2 - fs/inode.c | 40 ++++++------ fs/sync.c | 2 +- fs/xfs/xfs_file.c | 6 -- fs/xfs/xfs_super.c | 12 +--- include/linux/fs.h | 25 +++++-- 13 files changed, 143 insertions(+), 103 deletions(-) base-commit: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 -- 2.30.0
