On Sat, Nov 07, 2020 at 11:58:18PM +0800, Chunguang Xu wrote: > From: Chunguang Xu <brookxu@xxxxxxxxxxx> > > When freeing metadata, we will create an ext4_free_data and > insert it into the pending free list. After the current > transaction is committed, the object will be freed. > > ext4_mb_free_metadata() will check whether the area to be > freed overlaps with the pending free list. If true, return > directly. At this time, ext4_free_data is leaked. Fortunately, > the probability of this problem is relatively small, maybe we > should fix this problem. > > Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx> Thanks, applied. I added an explanatory note that the leak would only happen when the file system is corrupted (a block claimed by more than one inode, with those inodes deleted within a single jbd2 transaction). - Ted