Re: [PATCH RESEND 1/8] ext4: use ext4_assert() to replace J_ASSERT()

["Theodore Y. Ts'o" <tytso@xxxxxxx>]

On Sat, Nov 07, 2020 at 11:58:11PM +0800, Chunguang Xu wrote:
> From: Chunguang Xu <brookxu@xxxxxxxxxxx>
> 
> There are currently multiple forms of assertion, such as J_ASSERT().
> J_ASEERT() is provided for the jbd module, which is a public module.
> Maybe we should use custom ASSERT() like other file systems, such as
> xfs, which would be better.
> 
> Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>
> Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

Thanks, applied --- but I changed ext4_assert() to ASSERT().  All caps
makes it easier to spot the assertion, and since ext4.h is a private
header file, there's no reason to use a "ext4_" or "EXT4_" prefix.

       	     	     	       	  - Ted