On Wed, Jul 22, 2020 at 09:53:06AM +0100, David Howells wrote: > Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > > > Where are these FSINFO_FEAT* constants defined, and where are they > > documented? > > > > This generally looks ok to me, but I would like to see documentation > > first. > > Have a look at this branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fsinfo-core > > Patch "fsinfo: Provide a bitmap of supported features" > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=fsinfo-core&id=9d7651e966331f18c7bfe053237b3627585c3e79 > > Documentation: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=fsinfo-core&id=6bb357c42c96c2a5d72ff02d109ce49bd0c455ab Ah, thank you. The ext4 bits look ok to me. Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> (Looking forward to whenever you get to xfs... :)) --D > David >