On May 17, 2020, at 4:39 PM, Jonny Grant <jg@xxxxxxxx> wrote: > > > > On 11/05/2020 21:19, Andreas Dilger wrote: >> On May 8, 2020, at 2:36 PM, Jonny Grant <jg@xxxxxxxx> wrote: >>> >>> Please find attached patch for review. >>> >>> 2020-05-08 Jonny Grant <jg@xxxxxxxx> >>> >>> tests: comment ext4_dir_entry_2 file_type member >>> >>> Cheers, Jonny >>> >> Hi Jonny, >> thanks for your patch. The patch itself looks reasonable, but can >> you please submit it as inline text next time. To avoid issues with >> whitespace formatting, you can use "git send-email" directly from >> the command-line after making a commit with this change in it. >> Also, the subject line of the patch should just have "ext4:" as the >> subsystem, you don't need the whole pathname for the file, like: >> ext4: add comment for ext4_dir_entry_2 file_type member >> Finally, you should add a line: >> Signed-off-by: Jonny Grant <jg@xxxxxxxx> >> to indicate that you wrote the patch and you are OK with others using it. >> See Documentation/process/submitting-patches.rst for full details. >> Cheers, Andreas > > > Many thanks for your reply Andreas. I will follow your that patch guide, thank you for the link. > > Could I check, did you submit, or shall I submit via git send-email ? I didn't submit it. Best if you do so with the appropriate changes. Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
