On Sun, Apr 26, 2020 at 06:34:37PM -0700, Harshad Shirwadkar wrote: > ext4_mark_inode_dirty() can fail for real reasons. Ignoring its return > value may lead ext4 to ignore real failures that would result in > corruption / crashes. Harden ext4_mark_inode_dirty error paths to fail > as soon as possible and return errors to the caller whenever > appropriate. > > One of the possible scnearios when this bug could affected is that > while creating a new inode, its directory entry gets added > successfully but while writing the inode itself mark_inode_dirty > returns error which is ignored. This would result in inconsistency > that the directory entry points to a non-existent inode. > > Ran gce-xfstests smoke tests and verified that there were no > regressions. > > Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@xxxxxxxxx> Applied, thanks. - Ted
