On Tue 21-04-20 01:04:05, Christoph Hellwig wrote: > On Tue, Apr 21, 2020 at 03:08:50PM +1000, Dave Chinner wrote: > > > 4. fs/jbd2/journal.c > > > > Broken on filesystems where the journal file might be placed beyond > > a 32 bit block number, iomap_bmap() just makes that obvious. Needs > > fixing. > > I think this wants to use iomap, as that would solve all the problems. Well, there are two problems with this - firstly, ocfs2 is also using jbd2 and it knows nothing about iomap. So that would have to be implemented. Secondly, you have to somehow pass iomap ops to jbd2 so it all boils down to passing some callback to jbd2 during journal init to map blocks anyway as Dave said. And then it is upto filesystem to do the mapping - usually directly using its internal block mapping function - so no need for iomap AFAICT. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
