I got it. You hate make_ext4fs, and me too. You don't like to merge this patch in upstream e2fsprogs to resolve the bug of make_ext4fs. Of course we will fix the bug on our ancient devices, we have to . If this problem fixed or this patch merges in latest e2fsprogs, we will backport the latest e2fsprogs. If not, we have no motivation to backport it. I don't know whether other android devices suffer this problem. If someone else come to complain this problem, you should consider to fix it. Best wishes. Ming -----邮件原件----- 发件人: Theodore Y. Ts'o [mailto:tytso@xxxxxxx] 发送时间: 2018年6月30日 21:04 收件人: Gaoming (ming, consumer BG) 抄送: linux-ext4@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Liqingchao (sorp); Shenchen (harry); miaoxie (A); yangfei (D); Renlipeng (OS driver) 主题: Re: 答复: 答复: 答复: 答复: [PATCH] ext4: e2fsprogs: fix inode bitmap num not integer,incompatible for ancient android devices On Sat, Jun 30, 2018 at 01:26:43AM +0000, Gaoming (ming, consumer BG) wrote: > Yes, it is caused by using 1024 blocksize. > It is historical problem, and I have to admit that's not good idea. I don't know why somebody choose it some years before. > It has been corrected two years before or more early. But some ancient devices exist. > It is not user data, no need to do file-based encryption. It is a small partition for some use. > > However, 1024 is legal though not good, somebody may use it. > And we should fix it. So you understand my position --- the reason why I've been pushing so hard is I'm trying to figure out how big of a problem this is. Specifically speaking, is this a Huawei-specific problem, or something across the entire Android ecosystem. I *thought* I had fixed most of the disaster back in 2011. There have periodic headaches where testers would discover problems where android handsets get bricked after doing a factory reset that I had tracked down to make_ext4fs, and the existence of make_ext4fs is not something I agreed to, and have been fighting for years. So I've been cleaning up after make_ext4fs for a while, even though it's not my responsiblity. (For one thing my work responsibilities are for data center servers at Google, *not* Android; for another, no one asked *me* before they came up with the abomination which is make_ext4fs.) So I don't feel particularly, or personally, responsible for bugs caused by make_ext4fs, because if it had been up to me, it would have never existed in the first place. If it's only in ancient Huawei devices, I don't see a strong reason to support his in upstream e2fsprogs. Are you really going to be backporting the latest e2fsprogs into these ancient Huawei devices? In my experience, the Android team has a hard enough time getting their Android partners to backport kernel fixes for severe security bugs into old Android devices --- never mind versions of e2fsprogs. If not, what's the point? Regards, - Ted
