Re: [PATCH 04/10] tests: replace perl usage with shell built-in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 04/10] tests: replace perl usage with shell built-in
From: "Theodore Y. Ts'o" <tytso@xxxxxxx>
Date: Fri, 22 Jun 2018 12:35:18 -0400
Cc: Andreas Dilger <adilger@xxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <20180504093212.4gcfkv756mfv42cx@rh_laptop>
References: <1525235166-6448-1-git-send-email-adilger@dilger.ca> <1525235166-6448-2-git-send-email-adilger@dilger.ca> <1525235166-6448-3-git-send-email-adilger@dilger.ca> <1525235166-6448-4-git-send-email-adilger@dilger.ca> <1525235166-6448-5-git-send-email-adilger@dilger.ca> <20180504093212.4gcfkv756mfv42cx@rh_laptop>
User-agent: Mutt/1.10.0 (2018-05-17)

On Fri, May 04, 2018 at 11:32:12AM +0200, Lukas Czerner wrote:
> 
> We can use this instead
> 
> printf 'x%.0s' {1..256}
>

Using printf is a bashism, so it fails on dash, and I suspect might be
problematic on folks trying to build e2fsprogs on FreeBSD.

Cheers,

					- Ted

References:
- [PATCH 00/10] test cleanups and minor improvements
  - From: Andreas Dilger
- [PATCH 01/10] tests: don't use a sparse test file
  - From: Andreas Dilger
- [PATCH 02/10] tests: don't unlink test image if SKIP_UNLINK set
  - From: Andreas Dilger
- [PATCH 03/10] tests: clean up $DEBUGFS_EXE usage in scripts
  - From: Andreas Dilger
- [PATCH 04/10] tests: replace perl usage with shell built-in
  - From: Andreas Dilger
- Re: [PATCH 04/10] tests: replace perl usage with shell built-in
  - From: Lukas Czerner

Prev by Date: Re: [PATCH 05/10] ext2fs: annotate superblock/inode offsets
Next by Date: Re: [PATCH 04/10] tests: replace perl usage with shell built-in
Previous by thread: Re: [PATCH 04/10] tests: replace perl usage with shell built-in
Next by thread: Re: [PATCH 04/10] tests: replace perl usage with shell built-in
Index(es):
- Date
- Thread

[Index of Archives] [Reiser Filesystem Development] [Ceph FS] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite National Park] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Device Mapper] [Linux Media]