On Tue, May 01, 2018 at 10:26:01PM -0600, Andreas Dilger wrote: > Add byte offsets for the fields in ext2_super_block and ext2_inode > for convenience when debugging on-disk structures. > > Signed-off-by: Andreas Dilger <adilger@xxxxxxxxx> Thanks, applied. By the way, the way I'pve normally get the byte offsets for the superblock is to use ./lib/ext2fs/tst_super_size. At the moment tst_super_size prints the offsets in decimal, and your patch adds offsets in hex. Right now, debugfs's hexdump and idump commands prints its offsets in octal, because of the precedence of od. What do people think? Should we standardize on some base in how we display and print offsets and hexdumps? - Ted
