On Saturday, May 26, 2018 1:31:21 AM IST Theodore Y. Ts'o wrote: > On Tue, May 22, 2018 at 09:31:05PM +0530, Chandan Rajendra wrote: > > This commit introduces a new parameter to mpage_readpage[s]() > > functions. This parameter contains pointers to functions that can be > > used to decrypt data read from the backing device. These are stored in > > the fscrypt_ctx structure and one of these functions is invoked after > > the read operation is completed. > > > > Signed-off-by: Chandan Rajendra <chandan@xxxxxxxxxxxxxxxxxx> > > Can you describe more of what you are doing here; specifically, you > deleted all of fs/ext4/readpage.c --- was this because you moved > functionality back into fs/mpage.c? Did you make sure all of the > local changes in fs/ext4/readpage was moved back to fs/mpage.c? > > If the goal is to refactor code to remove the need for > fs/ext4/readpage.c, you should probably make that be the first patch > as a prerequisite patch. And we then need to make sure we don't > accidentally break anyone else who might be using fs/mpage.c. Saying > a bit more about why you think the refactor is a good thing would also > be useful. I will split this patch into two as suggested by you. Also, I will update the commit messages. The patchset was based on next-20180503 tree. You can obtain it from "https://github.com/chandanr/linux.git ext4-encryption" -- chandan
