Re: [PATCH 2/7] jbd2: clarify bad journal block checksum message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon 19-02-18 21:30:33, Theodore Ts'o wrote:
> There were two error messages emitted by jbd2, one for a bad checksum
> for a jbd2 descriptor block, and one for a bad checksum for a jbd2
> data block.  Change the data block checksum error so that the two can
> be disambiguated.
> 
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza


> ---
>  fs/jbd2/recovery.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
> index f99910b69c78..a4967b27ffb6 100644
> --- a/fs/jbd2/recovery.c
> +++ b/fs/jbd2/recovery.c
> @@ -600,8 +600,8 @@ static int do_one_pass(journal_t *journal,
>  						success = -EFSBADCRC;
>  						printk(KERN_ERR "JBD2: Invalid "
>  						       "checksum recovering "
> -						       "block %llu in log\n",
> -						       blocknr);
> +						       "data block %llu in "
> +						       "log\n", blocknr);
>  						block_error = 1;
>  						goto skip_write;
>  					}
> -- 
> 2.16.1.72.g5be1f00a9a
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux