On Mon 19-02-18 21:30:32, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> ---
> fs/ext4/ioctl.c | 1 +
> fs/ext4/super.c | 4 ++++
> include/trace/events/ext4.h | 43 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 48 insertions(+)
>
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 7e99ad02f1ba..4d1b1575f8ac 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -481,6 +481,7 @@ static int ext4_shutdown(struct super_block *sb, unsigned long arg)
> return 0;
>
> ext4_msg(sb, KERN_ALERT, "shut down requested (%d)", flags);
> + trace_ext4_shutdown(sb, flags);
>
> switch (flags) {
> case EXT4_GOING_FLAGS_DEFAULT:
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 39bf464c35f1..756f515b762d 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -448,6 +448,7 @@ void __ext4_error(struct super_block *sb, const char *function,
> if (unlikely(ext4_forced_shutdown(EXT4_SB(sb))))
> return;
>
> + trace_ext4_error(sb, function, line);
> if (ext4_error_ratelimit(sb)) {
> va_start(args, fmt);
> vaf.fmt = fmt;
What are the 'error' tracepoints good for? So that you have occurrence of
ext4_error() calls in the same stream of events as other tracepoints?
Otherwise the patch looks good. You can add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
