On Wed, 2016-02-03 at 11:32 -0800, Darrick J. Wong wrote: > On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > > > This patch adds a line break for proc mb_groups display. > > > > Using 2 lines for output might break any existing users. > > > > Are there any? > > It's a multiline file if you have more than one blockgroup; this just makes it > so that you don't have to special-case BG 0. And existing scripts might do that now and might fail to do properly after this change. > IOW: mb_groups scripts already had to parse multiple lines, and most likely any > script parsing it would inject a newline after the header. I've no dog in this fight really. I just wanted to make it clear that this could cause existing scripts to fail. proc output is supposed to be unchanging except maybe adding new fields to existing lines. Your choice. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
