On Wed, Feb 03, 2016 at 10:30:32AM -0800, Joe Perches wrote: > On Wed, 2016-02-03 at 10:13 -0800, Darrick J. Wong wrote: > > On Wed, Feb 03, 2016 at 09:19:06PM +0800, Huaitong Han wrote: > > > This patch adds a line break for proc mb_groups display. > > Using 2 lines for output might break any existing users. > > Are there any? It's a multiline file if you have more than one blockgroup; this just makes it so that you don't have to special-case BG 0. IOW: mb_groups scripts already had to parse multiple lines, and most likely any script parsing it would inject a newline after the header. --D > > > > > > > Signed-off-by: Huaitong Han <huaitong.han@xxxxxxxxx> > > > --- > > > fs/ext4/mballoc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > > > index 61eaf74..4424b7b 100644 > > > --- a/fs/ext4/mballoc.c > > > +++ b/fs/ext4/mballoc.c > > > @@ -2285,7 +2285,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v) > > > if (group == 0) > > > seq_puts(seq, "#group: free frags first [" > > > " 2^0 2^1 2^2 2^3 2^4 2^5 2^6 " > > > - " 2^7 2^8 2^9 2^10 2^11 2^12 2^13 ]"); > > > + " 2^7 2^8 2^9 2^10 2^11 2^12 2^13 ]\n"); > > > > Oh, heh. > > > > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > --D > > > > > > > > i = (sb->s_blocksize_bits + 2) * sizeof(sg.info.bb_counters[0]) + > > > sizeof(struct ext4_group_info); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
