On Sat, Nov 21, 2015 at 10:06:44AM -0800, Christoph Hellwig wrote: > > --- a/tests/generic/158.out > > +++ b/tests/generic/158.out > > Try to dedupe a device > > -XFS_IOC_FILE_EXTENT_SAME: Permission denied > > +XFS_IOC_FILE_EXTENT_SAME: Invalid argument > > Try to dedupe to a dir > > -/mnt/test-158/dir1: Is a directory > > +TEST_DIR/test-158/dir1: Is a directory > > Try to dedupe to a device > > -dedupe: Permission denied > > +dedupe: Operation not supported > > Try to dedupe to a fifo > > -dedupe: Permission denied > > +dedupe: Operation not supported > > Shouldn't these be Invalid argument just like the > to a device case above or the clone case? I was trying to mirror the behavior of reflink, which spits out EOPNOTSUPP when the destination isn't a regular file and EINVAL when the source isn't a regular file. --D > > Otherwise looks good, > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
