> Shouldn't these be Invalid argument just like the > to a device case above or the clone case? E.g. something like this on top of your patch: diff --git a/tests/generic/158.out b/tests/generic/158.out index 1210429..dff3692 100644 --- a/tests/generic/158.out +++ b/tests/generic/158.out @@ -16,9 +16,9 @@ XFS_IOC_FILE_EXTENT_SAME: Invalid argument Try to dedupe to a dir TEST_DIR/test-158/dir1: Is a directory Try to dedupe to a device -dedupe: Operation not supported +dedupe: Invalid argument Try to dedupe to a fifo -dedupe: Operation not supported +dedupe: Invalid argument Try to dedupe an append-only file Dedupe two files Check scratch fs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html