>>>>> "Darrick" == Darrick J Wong <darrick.wong@xxxxxxxxxx> writes: Darrick> Well then let's change BLKZEROOUT to require O_DIRECT instead Darrick> of hiding the coherency problem, That would break existing users, though. Darrick> A further optimization to mke2fs would be to detect that we've Darrick> run discard-with-zeroes and therefore can skip issuing Darrick> subsequent zeroouts on the same ranges, but I'm wary that Darrick> discard-zeroes-data does what it purports to do. It's dubious. I'm working on making sure we only set discard_zeroes_data when the device guarantees it for 3.19. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html