On Wed, Aug 27, 2014 at 09:15:46PM -0400, Theodore Ts'o wrote:
> On Sat, Aug 16, 2014 at 04:47:01PM -0700, Darrick J. Wong wrote:
> > diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> > index 7cbb99b..9924285 100644
> > --- a/misc/dumpe2fs.c
> > +++ b/misc/dumpe2fs.c
> > @@ -415,8 +415,10 @@ static void print_inline_journal_information(ext2_filsys fs)
> > if (jsb->s_feature_compat &
> > ext2fs_cpu_to_be32(JFS_FEATURE_COMPAT_CHECKSUM))
> > printf("%s", _("Journal checksum type: crc32\n"));
> > - if (jsb->s_feature_incompat &
> > - ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2))
> > + if ((jsb->s_feature_incompat &
> > + ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2)) ||
> > + (jsb->s_feature_incompat &
> > + ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2)))
>
> I assume this should really be:
>
> + if ((jsb->s_feature_incompat &
> + ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V2)) ||
> + (jsb->s_feature_incompat &
> + ext2fs_cpu_to_be32(JFS_FEATURE_INCOMPAT_CSUM_V3)))
> ^^^^
>
> amd similarly below in the next if statement?
Err... oops. Yes, you are correct. Thank you for catching this.
--D
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
