On Mon, Jul 28, 2014 at 09:17:42AM -0400, Theodore Ts'o wrote: > On Mon, Jul 28, 2014 at 11:11:45AM +0200, Lukáš Czerner wrote: > > > > I very much agree with that, that's why I was quite surprised that I > > found out recently that this is the default. I was living in the > > delusion that the default was ERRORS_RO for as long as I can remember. > > So my question is, should we change it ? This really does not seem > > like a sane default. > > Yeah, I've been thinking that this would be a good thing to change for > 1.43. > > The only reason that errors=continue was the default was for > historical reasons. I could imagine some system administrators being > surprised when all of a sudden their production systems start getting > lots of EROFS errors getting reported by applications. So I could > potentially imagine some Help Desks / Support folks at distributions > not being enthusiastic about such a change. > > Hmm.... we are starting to have some errors where we can allow the > system to stagger on, even if we need to disallow new allocations in > some block groups. I wonder if it is worthwhile to have a "continue > for correctable errors". The danger, of course, is that some errors, > even if they are correctable, (such as freeing a block which is > already freed), could be a hint that there are other fs corruptions, > not yet detected, that might lead to data loss if we reboot and fsck, > or remount readonly right away. So the question is while there is > some value, is it worth the added complexity to add an > "errors=continue-correctable" option? Back in the earlier 3.15 days when I was trying to figure out what was going on with that corruption bug that Eric Whitney found, it was useful for the kernel to be able to stumble on with the non-broken block groups long enough to save the logs of what had happened. (Laptops don't seem to have serial consoles...) In general I think it's worth the effort. (I'd shovel crash reports into pstore if I wasn't afraid of bricking UEFI.) --D > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
