On Thu, 26 Jun 2014, Lukáš Czerner wrote: > Date: Thu, 26 Jun 2014 18:28:57 +0200 (CEST) > From: Lukáš Czerner <lczerner@xxxxxxxxxx> > To: Theodore Ts'o <tytso@xxxxxxx> > Cc: linux-ext4@xxxxxxxxxxxxxxx, jack@xxxxxxx, stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ext4: Fix punch hole on files with indirect mapping > > On Thu, 26 Jun 2014, Theodore Ts'o wrote: > > > Date: Thu, 26 Jun 2014 12:24:50 -0400 > > From: Theodore Ts'o <tytso@xxxxxxx> > > To: Lukas Czerner <lczerner@xxxxxxxxxx> > > Cc: linux-ext4@xxxxxxxxxxxxxxx, jack@xxxxxxx, stable@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] ext4: Fix punch hole on files with indirect mapping > > > > I like the performance improvement of your patch, but I'm concerned > > that it might be a bit too complicated to push outside of the merge > > window. > > > > So what I propose doing is this. We'll take Jan's patches and after > > testing, we'll push it to Linus. Then for the the 3.17 merge window, > > after we've had more opportunity for testing and for other folks to > > review your changes, we can queue this patch (or its successor). > > > > Does that seem like a good path forward? > > > > - Ted > > It does. But this is not exactly a critical bug and it has been > there since the introduction of punch hole for indirect file. But I > guess it's better to fix it sooner rather than later, so I am fine > with this. It's also better to send Jan's fix to stable trees and let my fix be just in the Linus tree since it's quite big for stable I think. -Lukas > > Thanks! > -Lukas > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html >