On Tue, 17 Jun 2014, Jeff Liu wrote:
> Date: Tue, 17 Jun 2014 22:32:54 +0800
> From: Jeff Liu <jeff.liu@xxxxxxxxxx>
> To: Theodore Ts'o <tytso@xxxxxxx>, Andreas Dilger <adilger@xxxxxxxxx>
> Cc: linux-ext4@xxxxxxxxxxxxxxx
> Subject: [PATCH 20/24] ext4: return actual error on ext4_init_fs
>
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>
> Return the actual error code if call kset_create_and_add() failed
Considering the rest of the series this looks good to me. Thanks!
Reviewed-by: Lukas Czerner <lczerner@xxxxxxxxxx>
>
> Cc: Theodore Ts'o <tytso@xxxxxxx>
> Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx>
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> ---
> fs/ext4/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index b9b9aab..5912193 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5545,8 +5545,8 @@ static int __init ext4_init_fs(void)
> if (err)
> goto out6;
> ext4_kset = kset_create_and_add("ext4", NULL, fs_kobj);
> - if (!ext4_kset) {
> - err = -ENOMEM;
> + if (IS_ERR(ext4_kset)) {
> + err = PTR_ERR(ext4_kset);
> goto out5;
> }
> ext4_proc_root = proc_mkdir("fs/ext4", NULL);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
