On Thu, Jun 12, 2014 at 7:36 PM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
> IOWS: your commit log says what, but not why.
Will upload a version with some more "why".
> You're adding a new high-level IOCTL, so let's get a bit more
> visibility than just linux-ext4; linux-fsdevel cc'd.
Wasn't too sure about that one, because I didn't feel like committing
to other FSes for now even if they do have FITRIM.
Will remember to include them.
>> + if (secure_trim && !blk_queue_secdiscard(q))
>> + return -EOPNOTSUPP;
>> +
>> + if (EXT4_HAS_RO_COMPAT_FEATURE(sb,
>> + EXT4_FEATURE_RO_COMPAT_BIGALLOC)) {
>> + ext4_msg(sb, KERN_ERR,
>> + "FITRIM not supported with bigalloc");
>> + return -EOPNOTSUPP;
>> + }
>> +
>
> This last conditional is unrelated to the patch; if BIGALLOC has another
> incomplete part of its implementation, please send it as a standalone patch,
> not buried in this one.
Yup. My bad.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
