On Thu, Jun 12, 2014 at 7:36 PM, Darrick J. Wong
<darrick.wong@xxxxxxxxxx> wrote:
> What is 'secure discard'? How does it differ from regular discard?
> I guess it means 'really make this go away physical media'?
It tells the device to really get rid of all the data for the sectors
and not just put them back into the pool of free ones. Mostly useful
for flash storage. eMMC spec introduces secure erase which is
currently used for other things than secure trimming. The eMMC
controller is then responsible for making sure the data is not
available anymore.
>> + if (secure_trim && !blk_queue_secdiscard(q))
>> + return -EOPNOTSUPP;
>> +
>> + if (EXT4_HAS_RO_COMPAT_FEATURE(sb,
>> + EXT4_FEATURE_RO_COMPAT_BIGALLOC)) {
>> + ext4_msg(sb, KERN_ERR,
>> + "FITRIM not supported with bigalloc");
>> + return -EOPNOTSUPP;
>> + }
>
> Huh? I don't think this belongs in this patch.
Yuck. Messed up cherry-pick without paying enough attention. Will clean up.
> Also, any plans to bring SFITRIM to the other FSes?
Probably any FS with the plumbing for some form of secure discard and
FITRIM should be easy enough.
Have not looked into it yet beyond ext4 and F2FS.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
