On Thu, Mar 06, 2014 at 12:14:39PM -0800, Darrick J. Wong wrote: > > I'm already queuing up a bunch of (more) fixes... there's more weird things I > didn't notice. Such as, why is current_fs now defined in current_inode.h? > That really ought to have stayed in debugfs.c, and current_inode.h should have > 'extern ext2_filsys current_fs;', no? Yes, that would be better --- although in the long term we should probably try to get rid of the global variable and pass in an "fs" parameter into functions in misc/create_inode.c. Since these aren't in a shared library, I wasn't worried that much about the details of the abstraction interface, but I'm sure there are some ways that we can improve things. BTW, one of my plans for 1.43 is to rename libquota.a to libe2int.a, and to move things like profile.c, and other files shared between misc and e2fsck, etc., into an "internal support" library. I suspect create_inoode.c would be a candidate for moving into this internal support library. Cheers, > ...I'll also respin the patchset I sent out a few days ago. Sorry for having you respin the patchset yet again --- although hopefully it should be easier this time around. I'm trying to be fair in catching up with th e2fsprogs backlog, and Robert and Zheng's patches have been outstanding for a long time. Don't worry, yours are next on the list. :-) Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
