On Thu, Mar 06, 2014 at 11:06:22AM -0800, Darrick J. Wong wrote:
> I noticed a few things while merging -next into my dev tree...
Darrick, good catch!
> > + retval = ext2fs_new_inode(current_fs, cwd, 010755, 0, &newfile);
> > + if (retval) {
> > + com_err(__func__, retval, 0);
> > + close(fd);
> > + return errno;
>
> Why return errno here, instead of retval?
Yep, we should do s/errno/retval/ at the places that you noted.
Robert, since these are in next already, could you submit a patch to
fixt this up?
Thanks!!
- Ted
P.S. Fortunately, this isn't crypto code ala gnutls. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
