Re: [PATCH v2 19/28] mke2fs: add inline_data support in mke2fs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 03, 2013 at 02:30:26PM -0800, Darrick J. Wong wrote:
[...]
> > +		 * notify users that inline data will never be useful.
> > +		 */
> > +		if ((fs_param.s_feature_incompat &
> > +		     EXT4_FEATURE_INCOMPAT_INLINE_DATA) &&
> > +		    inode_size == EXT2_GOOD_OLD_INODE_SIZE) {
> 
> Perhaps I'm missing something here, but why is it impossible to use i_blocks
> for inline data even if there's no space for EAs?

If I understand correctly, on kernel side, we determine an inode has
inline data according to whether we have 'system.data' xattr entry on
inode extended attribute space.  If an inode doesn't have enough space
to store an entry with 'system.data', we just think this inode doesn't
has inline data.  So that is why I add this sanity check.

Regards,
                                                - Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux