On Tue, Dec 03, 2013 at 08:11:46PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
>
> Now inline_data doesn't depend on ext_attr. Hence we don't need to do
> this sanity check. But if the inode size is too small (128 bytes),
> inline_data will be useless because we couldn't save data in ibody
> extented attribute. So we need to report this error.
>
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> ---
> misc/mke2fs.8.in | 3 +++
> misc/mke2fs.c | 18 ++++++++++++++++--
> 2 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index 7b89296..c5e1abb 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -587,6 +587,9 @@ option).
> @JDEV@must be created with the same
> @JDEV@block size as the filesystems that will be using it.
> .TP
> +.B inline_data
> +Allow data to be stored in the inode and extented attribute area
"extended"
> +.TP
> .B large_file
> Filesystem can contain files that are greater than 2GB. (Modern kernels
> set this feature automatically when a file > 2GB is created.)
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 67c9225..0a3880f 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -929,7 +929,8 @@ static __u32 ok_features[3] = {
> EXT2_FEATURE_INCOMPAT_META_BG|
> EXT4_FEATURE_INCOMPAT_FLEX_BG|
> EXT4_FEATURE_INCOMPAT_MMP |
> - EXT4_FEATURE_INCOMPAT_64BIT,
> + EXT4_FEATURE_INCOMPAT_64BIT|
> + EXT4_FEATURE_INCOMPAT_INLINE_DATA,
> /* R/O compat */
> EXT2_FEATURE_RO_COMPAT_LARGE_FILE|
> EXT4_FEATURE_RO_COMPAT_HUGE_FILE|
> @@ -2069,7 +2070,8 @@ profile_error:
> "See https://ext4.wiki.kernel.org/";
> "index.php/Quota for more information\n\n"));
>
> - /* Since sparse_super is the default, we would only have a problem
> + /*
> + * Since sparse_super is the default, we would only have a problem
> * here if it was explicitly disabled.
> */
> if ((fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_RESIZE_INODE) &&
> @@ -2125,6 +2127,18 @@ profile_error:
> blocksize);
> exit(1);
> }
> + /*
> + * If inode size is 128 and inline data is enable, we need to
"is enabled"
> + * notify users that inline data will never be useful.
> + */
> + if ((fs_param.s_feature_incompat &
> + EXT4_FEATURE_INCOMPAT_INLINE_DATA) &&
> + inode_size == EXT2_GOOD_OLD_INODE_SIZE) {
Perhaps I'm missing something here, but why is it impossible to use i_blocks
for inline data even if there's no space for EAs?
--D
> + com_err(program_name, 0,
> + _("inode size is %d, inline data is useless"),
> + inode_size);
> + exit(1);
> + }
> fs_param.s_inode_size = inode_size;
> }
>
> --
> 1.7.9.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
