On Fri, Apr 12, 2013 at 08:24:06PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
>
> Now jbd_alloc_handle is only called by new_handle. So this commit
> uses kmem_cache_zalloc instead of kmem_cache_alloc/memset.
>
> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
Hi Jan,
Sorry, I forgot to Cc you. Could you please take a look at this patch?
Thanks,
- Zheng
> ---
> fs/jbd/transaction.c | 1 -
> include/linux/jbd.h | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 071d690..e3e255c 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -245,7 +245,6 @@ static handle_t *new_handle(int nblocks)
> handle_t *handle = jbd_alloc_handle(GFP_NOFS);
> if (!handle)
> return NULL;
> - memset(handle, 0, sizeof(*handle));
> handle->h_buffer_credits = nblocks;
> handle->h_ref = 1;
>
> diff --git a/include/linux/jbd.h b/include/linux/jbd.h
> index c8f3297..7e0b622 100644
> --- a/include/linux/jbd.h
> +++ b/include/linux/jbd.h
> @@ -887,7 +887,7 @@ extern struct kmem_cache *jbd_handle_cache;
>
> static inline handle_t *jbd_alloc_handle(gfp_t gfp_flags)
> {
> - return kmem_cache_alloc(jbd_handle_cache, gfp_flags);
> + return kmem_cache_zalloc(jbd_handle_cache, gfp_flags);
> }
>
> static inline void jbd_free_handle(handle_t *handle)
> --
> 1.7.12.rc2.18.g61b472e
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
