So, right direction add ability to mark a page as active in lru pagevec array ? just a bypass a IS_IN_LRU(page) check and fix moving to LRU to ability to put into active LRU list from pagevec ? I may prepare a patch for it. On Apr 25, 2013, at 00:41, Andrew Morton wrote: > On Wed, 24 Apr 2013 10:26:50 -0400 "Theodore Ts'o" <tytso@xxxxxxx> wrote: > >> On Tue, Apr 23, 2013 at 03:00:08PM -0700, Andrew Morton wrote: >>> That should fix things for now. Although it might be better to just do >>> >>> mark_page_accessed(page); /* to SetPageReferenced */ >>> lru_add_drain(); /* to SetPageLRU */ >>> >>> Because a) this was too early to decide that the page is >>> super-important and b) the second touch of this page should have a >>> mark_page_accessed() in it already. >> >> The question is do we really want to put lru_add_drain() into the ext4 >> file system code? That seems to pushing some fairly mm-specific >> knowledge into file system code. I'll do this if I have to do, but >> wouldn't be better if this was pushed into mark_page_accessed(), or >> some other new API was exported by the mm subsystem? > > Sure, that would be daft. We'd add a new > mark_page_accessed_right_now_dont_use_this() to mm/swap.c > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
