Re: [PATCH] ext4: take i_mutex in ext4_symlink to eliminate a warning from ext4_truncate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 27, 2013 at 11:19:22PM +0800, Zheng Liu wrote:
> > > Otherwise, couldn't we end up with problems where a failed write calls
> > > ext4_truncate() without i_data_sem(), and that races with something
> > > else --- say, a punch or truncate call to that same inode?
> 
> Let me think about it.  I need to take a close look at it.

Note that I'm not so concerned when we are creating symlink --- you
are quite right in pointing out in that case the inode isn't in the
namespace yet, so that prevents races --- but also what might happen
in an ENOSPC write(2) failure racing against a punch/truncate call.

But again, this is why I added the warning --- it was to find these
edge cases that we might not have considered.  :-)

     	   	   	     	  	       - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux